]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mm/damon/sysfs-schemes: remove outdated TODO in target_nid_store()
authorSwaraj Gaikwad <swarajgaikwad1925@gmail.com>
Thu, 11 Dec 2025 03:27:22 +0000 (03:27 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 21 Jan 2026 03:24:41 +0000 (19:24 -0800)
The TODO comment in target_nid_store() suggested adding range validation
for target_nid.  As discussed in [1], the current behavior of accepting
any integer value is intentional.  DAMON sysfs aims to remain flexible,
including supporting users who prepare node IDs before future NUMA hotplug
events.

Because this behavior matches the broader design philosophy of the DAMON
sysfs interface, the TODO comment is now misleading.  This patch removes
the comment without introducing any behavioral change.

No functional changes.

Link: https://lkml.kernel.org/r/20251211032722.4928-2-swarajgaikwad1925@gmail.com
Link: https://lore.kernel.org/lkml/20251210150930.57679-1-sj@kernel.org/
Signed-off-by: Swaraj Gaikwad <swarajgaikwad1925@gmail.com>
Suggested-by: SeongJae Park <sj@kernel.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs-schemes.c

index 3a699dcd5a7fe1529279e42eee874086f2fe9c2a..b52fc3b45b309815747a9672306168d9729f5559 100644 (file)
@@ -2288,7 +2288,6 @@ static ssize_t target_nid_store(struct kobject *kobj,
                        struct damon_sysfs_scheme, kobj);
        int err = 0;
 
-       /* TODO: error handling for target_nid range. */
        err = kstrtoint(buf, 0, &scheme->target_nid);
 
        return err ? err : count;