]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
stream: fix minor scan-build warning
authorVictor Julien <vjulien@oisf.net>
Fri, 21 Apr 2023 08:21:17 +0000 (10:21 +0200)
committerVictor Julien <vjulien@oisf.net>
Tue, 25 Apr 2023 09:36:37 +0000 (11:36 +0200)
stream-tcp.c:134:14: warning: Value stored to 'presize' during its initialization is never read [deadcode.DeadStores]
    uint64_t presize = SC_ATOMIC_GET(st_memuse);
             ^~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

(cherry picked from commit 0c151144502f262caaab40d74e4a4e8d485d38e5)

src/stream-tcp.c

index c63e4ec2a6b74d08bfe680a3b4053828bf6797c9..1555cbdd09d91e6b5ac938231c6ee01c1503a7d0 100644 (file)
@@ -137,7 +137,7 @@ void StreamTcpIncrMemuse(uint64_t size)
 
 void StreamTcpDecrMemuse(uint64_t size)
 {
-#ifdef DEBUG_VALIDATION
+#if defined(DEBUG_VALIDATION) && defined(UNITTESTS)
     uint64_t presize = SC_ATOMIC_GET(st_memuse);
     if (RunmodeIsUnittests()) {
         BUG_ON(presize > UINT_MAX);
@@ -146,7 +146,7 @@ void StreamTcpDecrMemuse(uint64_t size)
 
     (void) SC_ATOMIC_SUB(st_memuse, size);
 
-#ifdef DEBUG_VALIDATION
+#if defined(DEBUG_VALIDATION) && defined(UNITTESTS)
     if (RunmodeIsUnittests()) {
         uint64_t postsize = SC_ATOMIC_GET(st_memuse);
         BUG_ON(postsize > presize);