media: em28xx-video: fix missing res_free() on init_usb_xfer failure

res_get() is called before em28xx_init_usb_xfer(), but the error
path of em28xx_init_usb_xfer() does not release the resource,
leading to a persistent busy state.

Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
index 4a0ce9c5ee4b4abde681cc373e1c6db2f3b3af70..da0422c65e5f45aba712fcf007eece19c8ad0bf9 100644 (file)
--- a/drivers/media/usb/em28xx/em28xx-video.c
+++ b/drivers/media/usb/em28xx/em28xx-video.c
@@ -1248,8 +1248,10 @@ int em28xx_start_analog_streaming(struct vb2_queue *vq, unsigned int count)
                                          dev->max_pkt_size,
                                          dev->packet_multiplier,
                                          em28xx_urb_data_copy);
-               if (rc < 0)
+               if (rc < 0) {
+                       res_free(dev, vq->type);
                        return rc;
+               }
 
                /*
                 * djh: it's not clear whether this code is still needed.  I'm