remove unnecessary checks for app_io decoder

diff --git a/src/listen/bfd/proto_bfd.c b/src/listen/bfd/proto_bfd.c
index 4ddc684775442cd4d8f712421e9d23e4cd227d7c..1831c6ed7339494c43f27593ac90462e2a22c703 100644 (file)
--- a/src/listen/bfd/proto_bfd.c
+++ b/src/listen/bfd/proto_bfd.c
@@ -175,9 +175,8 @@ static int auth_type_parse(UNUSED TALLOC_CTX *ctx, void *out, UNUSED void *paren
 /** Decode the packet
  *
  */
-static int mod_decode(void const *instance, request_t *request, uint8_t *const data, size_t data_len)
+static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *const data, size_t data_len)
 {
-       proto_bfd_t const       *inst = talloc_get_type_abort_const(instance, proto_bfd_t);
        fr_io_track_t const     *track = talloc_get_type_abort_const(request->async->packet_ctx, fr_io_track_t);
        fr_io_address_t const   *address = track->address;
        fr_client_t const       *client;
@@ -282,12 +281,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
                }
        }
 
-       if (!inst->io.app_io->decode) return 0;
-
-       /*
-        *      Let the app_io do anything it needs to do.
-        */
-       return inst->io.app_io->decode(inst->io.app_io_instance, request, data, data_len);
+       return 0;
 }
 
 static ssize_t mod_encode(UNUSED void const *instance, request_t *request, uint8_t *buffer, size_t buffer_len)

diff --git a/src/listen/dhcpv4/proto_dhcpv4.c b/src/listen/dhcpv4/proto_dhcpv4.c
index f112bcae0710535458fa551217bcaa5a8d2b78a6..2436d7dc9ea78388ab6545bb7ee5b296f9aaa0f8 100644 (file)
--- a/src/listen/dhcpv4/proto_dhcpv4.c
+++ b/src/listen/dhcpv4/proto_dhcpv4.c
@@ -190,9 +190,8 @@ static int transport_parse(TALLOC_CTX *ctx, void *out, UNUSED void *parent,
 /** Decode the packet
  *
  */
-static int mod_decode(void const *instance, request_t *request, uint8_t *const data, size_t data_len)
+static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *const data, size_t data_len)
 {
-       proto_dhcpv4_t const *inst = talloc_get_type_abort_const(instance, proto_dhcpv4_t);
        fr_io_track_t const *track = talloc_get_type_abort_const(request->async->packet_ctx, fr_io_track_t);
        fr_io_address_t const *address = track->address;
        fr_client_t const *client;
@@ -240,12 +239,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
 
        REQUEST_VERIFY(request);
 
-       if (!inst->io.app_io->decode) return 0;
-
-       /*
-        *      Let the app_io do anything it needs to do.
-        */
-       return inst->io.app_io->decode(inst->io.app_io_instance, request, data, data_len);
+       return 0;
 }
 
 static ssize_t mod_encode(UNUSED void const *instance, request_t *request, uint8_t *buffer, size_t buffer_len)

diff --git a/src/listen/dhcpv6/proto_dhcpv6.c b/src/listen/dhcpv6/proto_dhcpv6.c
index 21117a6262d300fd7a3b9522f854039a9122d3f8..608596081f3ae82c22ce210096b02a0ec75668f9 100644 (file)
--- a/src/listen/dhcpv6/proto_dhcpv6.c
+++ b/src/listen/dhcpv6/proto_dhcpv6.c
@@ -190,9 +190,8 @@ static int transport_parse(TALLOC_CTX *ctx, void *out, UNUSED void *parent,
 /** Decode the packet
  *
  */
-static int mod_decode(void const *instance, request_t *request, uint8_t *const data, size_t data_len)
+static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *const data, size_t data_len)
 {
-       proto_dhcpv6_t const    *inst = talloc_get_type_abort_const(instance, proto_dhcpv6_t);
        fr_io_track_t const     *track = talloc_get_type_abort_const(request->async->packet_ctx, fr_io_track_t);
        fr_io_address_t const   *address = track->address;
        fr_client_t const               *client;
@@ -239,12 +238,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
 
        REQUEST_VERIFY(request);
 
-       if (!inst->io.app_io->decode) return 0;
-
-       /*
-        *      Let the app_io do anything it needs to do.
-        */
-       return inst->io.app_io->decode(inst->io.app_io_instance, request, data, data_len);
+       return 0;
 }
 
 static ssize_t mod_encode(UNUSED void const *instance, request_t *request, uint8_t *buffer, size_t buffer_len)

diff --git a/src/listen/dns/proto_dns.c b/src/listen/dns/proto_dns.c
index 2763c18edd041897006ca28ffb16227756e71157..b2784f499f50aa70b9e71ef326fc9f8d0e444af3 100644 (file)
--- a/src/listen/dns/proto_dns.c
+++ b/src/listen/dns/proto_dns.c
@@ -171,9 +171,8 @@ static int transport_parse(TALLOC_CTX *ctx, void *out, UNUSED void *parent,
 /** Decode the packet
  *
  */
-static int mod_decode(void const *instance, request_t *request, uint8_t *const data, size_t data_len)
+static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *const data, size_t data_len)
 {
-       proto_dns_t const       *inst = talloc_get_type_abort_const(instance, proto_dns_t);
        fr_io_track_t const     *track = talloc_get_type_abort_const(request->async->packet_ctx, fr_io_track_t);
        fr_io_address_t const   *address = track->address;
        fr_client_t const               *client;
@@ -230,12 +229,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
 
        REQUEST_VERIFY(request);
 
-       if (!inst->io.app_io->decode) return 0;
-
-       /*
-        *      Let the app_io do anything it needs to do.
-        */
-       return inst->io.app_io->decode(inst->io.app_io_instance, request, data, data_len);
+       return 0;
 }
 
 static ssize_t mod_encode(UNUSED void const *instance, request_t *request, uint8_t *buffer, size_t buffer_len)

diff --git a/src/listen/radius/proto_radius.c b/src/listen/radius/proto_radius.c
index e12283ece78c2d2d15aa14572c77ca41a283caf5..1916bc857d32f18d6e7a19eb33aec13968468b40 100644 (file)
--- a/src/listen/radius/proto_radius.c
+++ b/src/listen/radius/proto_radius.c
@@ -197,9 +197,8 @@ static int transport_parse(TALLOC_CTX *ctx, void *out, UNUSED void *parent, CONF
 /** Decode the packet
  *
  */
-static int mod_decode(void const *instance, request_t *request, uint8_t *const data, size_t data_len)
+static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *const data, size_t data_len)
 {
-       proto_radius_t const    *inst = talloc_get_type_abort_const(instance, proto_radius_t);
        fr_io_track_t const     *track = talloc_get_type_abort_const(request->async->packet_ctx, fr_io_track_t);
        fr_io_address_t const   *address = track->address;
        fr_client_t const               *client;
@@ -306,12 +305,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
                request->async->sequence = 1;
        }
 
-       if (!inst->io.app_io->decode) return 0;
-
-       /*
-        *      Let the app_io do anything it needs to do.
-        */
-       return inst->io.app_io->decode(inst->io.app_io_instance, request, data, data_len);
+       return 0;
 }
 
 static ssize_t mod_encode(UNUSED void const *instance, request_t *request, uint8_t *buffer, size_t buffer_len)

diff --git a/src/listen/tacacs/proto_tacacs.c b/src/listen/tacacs/proto_tacacs.c
index be02c105e1aa9fcb3720de991ca4acce8452dd34..5a393a19fe78b212539683dd1b389101869dfbcb 100644 (file)
--- a/src/listen/tacacs/proto_tacacs.c
+++ b/src/listen/tacacs/proto_tacacs.c
@@ -185,9 +185,8 @@ static int transport_parse(TALLOC_CTX *ctx, void *out, UNUSED void *parent, CONF
 /** Decode the packet
  *
  */
-static int mod_decode(void const *instance, request_t *request, uint8_t *const data, size_t data_len)
+static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *const data, size_t data_len)
 {
-       proto_tacacs_t const    *inst = talloc_get_type_abort_const(instance, proto_tacacs_t);
        fr_io_track_t const     *track = talloc_get_type_abort_const(request->async->packet_ctx, fr_io_track_t);
        fr_io_address_t const   *address = track->address;
        fr_client_t const               *client;
@@ -343,12 +342,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
                }
        }
 
-       if (!inst->io.app_io->decode) return 0;
-
-       /*
-        *      Let the app_io do anything it needs to do.
-        */
-       return inst->io.app_io->decode(inst->io.app_io_instance, request, data, data_len);
+       return 0;
 }
 
 static ssize_t mod_encode(UNUSED void const *instance, request_t *request, uint8_t *buffer, size_t buffer_len)

diff --git a/src/listen/vmps/proto_vmps.c b/src/listen/vmps/proto_vmps.c
index 7a931b0a50b3ca3099d100d01854036b3d50f07f..77d253b6c69a8675544d40067ee5cacf55d4dda2 100644 (file)
--- a/src/listen/vmps/proto_vmps.c
+++ b/src/listen/vmps/proto_vmps.c
@@ -178,9 +178,8 @@ static int transport_parse(TALLOC_CTX *ctx, void *out, UNUSED void *parent,
 /** Decode the packet
  *
  */
-static int mod_decode(void const *instance, request_t *request, uint8_t *const data, size_t data_len)
+static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *const data, size_t data_len)
 {
-       proto_vmps_t const *inst = talloc_get_type_abort_const(instance, proto_vmps_t);
        fr_io_track_t const *track = talloc_get_type_abort_const(request->async->packet_ctx, fr_io_track_t);
        fr_io_address_t const *address = track->address;
        fr_client_t const *client;
@@ -231,12 +230,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
 
        REQUEST_VERIFY(request);
 
-       if (!inst->io.app_io->decode) return 0;
-
-       /*
-        *      Let the app_io do anything it needs to do.
-        */
-       return inst->io.app_io->decode(inst->io.app_io_instance, request, data, data_len);
+       return 0;
 }
 
 static ssize_t mod_encode(UNUSED void const *instance, request_t *request, uint8_t *buffer, size_t buffer_len)