]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Don't require secdrivers to implement .domainMoveImageMetadata
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 18 May 2020 08:07:30 +0000 (10:07 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 18 May 2020 08:08:10 +0000 (10:08 +0200)
The AppArmor secdriver does not use labels to grant access to
resources. Therefore, it doesn't use XATTRs and hence it lacks
implementation of .domainMoveImageMetadata callback. This leads
to a harmless but needless error message appearing in the logs:

  virSecurityManagerMoveImageMetadata:476 : this function is not
  supported by the connection driver: virSecurityManagerMoveImageMetadata

Closes: https://gitlab.com/libvirt/libvirt/-/issues/25
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/security/security_manager.c

index 2dea2947844ec1d2b024ab6482432ba78aef9102..b1237d63b6a4a97a8e0c3868e93ef62f38ba1a0d 100644 (file)
@@ -473,8 +473,7 @@ virSecurityManagerMoveImageMetadata(virSecurityManagerPtr mgr,
         return ret;
     }
 
-    virReportUnsupportedError();
-    return -1;
+    return 0;
 }