usb: dwc3: imx8mp: fix device leak at unbind

[ Upstream commit 086a0e516f7b3844e6328a5c69e2708b66b0ce18 ]

Make sure to drop the reference to the dwc3 device taken by
of_find_device_by_node() on probe errors and on driver unbind.

Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver")
Cc: stable@vger.kernel.org	# 5.12
Cc: Li Jun <jun.li@nxp.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20250724091910.21092-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
index 174f07614318b3b09dcb260c9e6c00ba8b345d26..d721f45cec9a428fa3375a2973ec67b5e9b4c344 100644 (file)
--- a/drivers/usb/dwc3/dwc3-imx8mp.c
+++ b/drivers/usb/dwc3/dwc3-imx8mp.c
@@ -243,7 +243,7 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
                                        IRQF_ONESHOT, dev_name(dev), dwc3_imx);
        if (err) {
                dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
-               goto depopulate;
+               goto put_dwc3;
        }
 
        device_set_wakeup_capable(dev, true);
@@ -251,6 +251,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
 
        return 0;
 
+put_dwc3:
+       put_device(&dwc3_imx->dwc3->dev);
 depopulate:
        of_platform_depopulate(dev);
 err_node_put:
@@ -271,6 +273,8 @@ static int dwc3_imx8mp_remove(struct platform_device *pdev)
        struct dwc3_imx8mp *dwc3_imx = platform_get_drvdata(pdev);
        struct device *dev = &pdev->dev;
 
+       put_device(&dwc3_imx->dwc3->dev);
+
        pm_runtime_get_sync(dev);
        of_platform_depopulate(dev);