]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
schannel: fix revoke_best_effort setting for proxy
authorJoshua Rogers <MegaManSec@users.noreply.github.com>
Tue, 19 May 2026 21:32:26 +0000 (23:32 +0200)
committerJay Satiro <raysatiro@yahoo.com>
Wed, 20 May 2026 17:51:35 +0000 (13:51 -0400)
- Fix revoke_best_effort reading wrong ssl config.

Prior to this change the revoke_best_effort setting for the proxy was
wrongly ignored in favor of the same setting for the destination host.

In other words, CURLSSLOPT_REVOKE_BEST_EFFORT set via
CURLOPT_PROXY_SSL_OPTIONS did not apply to the proxy and
CURLSSLOPT_REVOKE_BEST_EFFORT set via CURLOPT_SSL_OPTIONS wrongly
applied to the proxy.

Closes https://github.com/curl/curl/pull/21683

lib/vtls/schannel_verify.c

index 486fd6e00581da8d706559fedec44a48a3e2b987..25b13955f2645a4796c3bf2767f87b78c85f3145 100644 (file)
@@ -805,7 +805,7 @@ CURLcode Curl_verify_certificate(struct Curl_cfilter *cf,
       DWORD dwTrustErrorMask = ~(DWORD)(CERT_TRUST_IS_NOT_TIME_NESTED);
       dwTrustErrorMask &= pSimpleChain->TrustStatus.dwErrorStatus;
 
-      if(data->set.ssl.revoke_best_effort) {
+      if(ssl_config->revoke_best_effort) {
         /* Ignore errors when root certificates are missing the revocation
          * list URL, or when the list could not be downloaded because the
          * server is currently unreachable. */