bpf: xfrm: drop dead NULL check in bpf_xdp_get_xfrm_state()

As KF_TRUSTED_ARGS is now considered the default for all kfuncs, the
opts parameter in bpf_xdp_get_xfrm_state() can never be NULL. Verifier
will detect this at load time and will not allow passing NULL to this
function. This matches the documentation above the kfunc that says this
parameter (opts) Cannot be NULL.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
Link: https://lore.kernel.org/r/20260102180038.2708325-5-puranjay@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

diff --git a/net/xfrm/xfrm_state_bpf.c b/net/xfrm/xfrm_state_bpf.c
index 2248eda741f8e0bfd03713bd6065e7ba7c70e2fa..4180c317f9bc4b71cc0bdee4ba9f9c76034d048f 100644 (file)
--- a/net/xfrm/xfrm_state_bpf.c
+++ b/net/xfrm/xfrm_state_bpf.c
@@ -68,7 +68,7 @@ bpf_xdp_get_xfrm_state(struct xdp_md *ctx, struct bpf_xfrm_state_opts *opts, u32
        struct net *net = dev_net(xdp->rxq->dev);
        struct xfrm_state *x;
 
-       if (!opts || opts__sz < sizeof(opts->error))
+       if (opts__sz < sizeof(opts->error))
                return NULL;
 
        if (opts__sz != BPF_XFRM_STATE_OPTS_SZ) {