]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
cpufreq: amd-pstate: Remove unnecessary driver_lock in set_boost
authorDhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Thu, 30 Jan 2025 08:52:52 +0000 (08:52 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:13:37 +0000 (11:13 +0200)
[ Upstream commit db1cafc77aaaf871509da06f4a864e9af6d6791f ]

set_boost is a per-policy function call, hence a driver wide lock is
unnecessary. Also this mutex_acquire can collide with the mutex_acquire
from the mode-switch path in status_store(), which can lead to a
deadlock. So, remove it.

Signed-off-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Acked-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cpufreq/amd-pstate.c

index 1b26845703f68cba53a68b0f9bd1bad04bb63f50..a27749d948b46434fabc9f31316589b068520bb8 100644 (file)
@@ -746,7 +746,6 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
                pr_err("Boost mode is not supported by this processor or SBIOS\n");
                return -EOPNOTSUPP;
        }
-       guard(mutex)(&amd_pstate_driver_lock);
 
        ret = amd_pstate_cpu_boost_update(policy, state);
        refresh_frequency_limits(policy);