]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: core: lock client_mutex while removing link components
authorRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Thu, 23 May 2019 17:12:01 +0000 (10:12 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Jul 2019 07:52:22 +0000 (09:52 +0200)
[ Upstream commit 34ac3c3eb8f0c07252ceddf0a22dd240e5c91ccb ]

Removing link components results in topology unloading. So,
acquire the client_mutex before removing components in
soc_remove_link_components. This will prevent the lockdep warning
seen when dai links are removed during topology removal.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/soc-core.c

index a7b4fab92f26c9a8b9d70705e0af782ecf187587..a4668a788ed50b0133c2a8906e860f97ad191b46 100644 (file)
@@ -1008,12 +1008,14 @@ static void soc_remove_link_components(struct snd_soc_card *card,
        struct snd_soc_component *component;
        struct snd_soc_rtdcom_list *rtdcom;
 
+       mutex_lock(&client_mutex);
        for_each_rtdcom(rtd, rtdcom) {
                component = rtdcom->component;
 
                if (component->driver->remove_order == order)
                        soc_remove_component(component);
        }
+       mutex_unlock(&client_mutex);
 }
 
 static void soc_remove_dai_links(struct snd_soc_card *card)