re PR fortran/91565 (ICE in gfc_simplify_reshape, at fortran/simplify.c:6707 etc.)

2019-08-30  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/91565
	* simplify.c (gfc_simplify_reshape): Add additional checks of the
	ORDER dummy argument.

2019-08-30  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/91565
	* gfortran.dg/pr91565.f90: New test.

From-SVN: r275230

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 52c6a8121f66e50fcee4f5fa4e1aefeb9cb038f7..3c607062fdfe75c1a7a2cbce41089b8219367810 100644 (file)
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,9 @@
+2019-08-30  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+       PR fortran/91565
+       * simplify.c (gfc_simplify_reshape): Add additional checks of the
+       ORDER dummy argument.
+
 2019-08-30  Steven G. Kargl  <kargl@gcc.gnu.org>
 
        PR fortran/91564

diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index 6c1f4bd4fce300c24b673925906f2bb0f0acc26c..ee159b19ee1940ae38d38efeab5543a40d7f7954 100644 (file)
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -6684,6 +6684,9 @@ gfc_simplify_reshape (gfc_expr *source, gfc_expr *shape_exp,
   mpz_init (index);
   rank = 0;
 
+  for (i = 0; i < GFC_MAX_DIMENSIONS; i++)
+    x[i] = 0;
+
   for (;;)
     {
       e = gfc_constructor_lookup_expr (shape_exp->value.constructor, rank);
@@ -6708,8 +6711,28 @@ gfc_simplify_reshape (gfc_expr *source, gfc_expr *shape_exp,
     }
   else
     {
-      for (i = 0; i < rank; i++)
-       x[i] = 0;
+      mpz_t size;
+      int order_size, shape_size;
+
+      if (order_exp->rank != shape_exp->rank)
+       {
+         gfc_error ("Shapes of ORDER at %L and SHAPE at %L are different",
+                    &order_exp->where, &shape_exp->where);
+         return &gfc_bad_expr;
+       }
+
+      gfc_array_size (shape_exp, &size);
+      shape_size = mpz_get_ui (size);
+      mpz_clear (size);
+      gfc_array_size (order_exp, &size);
+      order_size = mpz_get_ui (size);
+      mpz_clear (size);
+      if (order_size != shape_size)
+       {
+         gfc_error ("Sizes of ORDER at %L and SHAPE at %L are different",
+                    &order_exp->where, &shape_exp->where);
+         return &gfc_bad_expr;
+       }
 
       for (i = 0; i < rank; i++)
        {
@@ -6720,7 +6743,12 @@ gfc_simplify_reshape (gfc_expr *source, gfc_expr *shape_exp,
 
          gcc_assert (order[i] >= 1 && order[i] <= rank);
          order[i]--;
-         gcc_assert (x[order[i]] == 0);
+         if (x[order[i]] != 0)
+           {
+             gfc_error ("ORDER at %L is not a permutation of the size of "
+                        "SHAPE at %L", &order_exp->where, &shape_exp->where);
+             return &gfc_bad_expr;
+           }
          x[order[i]] = 1;
        }
     }

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index dc0d7f48f1e92389eafa6c59ea92a15b148a842d..6c46a5fd6bd9e311add2451c7b710270454d7abf 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-30  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+       PR fortran/91565
+       * gfortran.dg/pr91565.f90: New test.
+
 2019-08-30  Steven G. Kargl  <kargl@gcc.gnu.org>
 
        PR fortran/91564

diff --git a/gcc/testsuite/gfortran.dg/pr91565.f90 b/gcc/testsuite/gfortran.dg/pr91565.f90
new file mode 100644 (file)
index 0000000..b43a57a
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr91565.f90
@@ -0,0 +1,17 @@
+! { dg-do compile }
+! PR fortran/91565
+! Contributed by Gerhard Steinmetz
+program p
+   integer, parameter :: a(2) = [2,2]              ! { dg-error "\(1\)" }
+   print *, reshape([1,2,3,4,5,6], [2,3], order=a) ! { dg-error "not a permutation" }
+end
+
+subroutine foo
+   integer, parameter :: a(1) = 1                  ! { dg-error "\(1\)" }
+   print *, reshape([1,2,3,4,5,6], [2,3], order=a) ! { dg-error "are different" }
+end
+
+subroutine bar
+   integer, parameter :: a(1,2) = 1                ! { dg-error "\(1\)" }
+   print *, reshape([1,2,3,4,5,6], [2,3], order=a) ! { dg-error "are different" }
+end