]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
CVE-2022-3437 third_party/heimdal: Remove __func__ compatibility workaround
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Wed, 12 Oct 2022 00:56:08 +0000 (13:56 +1300)
committerJule Anger <janger@samba.org>
Tue, 25 Oct 2022 10:31:33 +0000 (10:31 +0000)
As described by the C standard, __func__ is a variable, not a macro.
Hence this #ifndef check does not work as intended, and only serves to
unconditionally disable __func__. A nonoperating __func__ prevents
cmocka operating correctly, so remove this definition.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15134

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
third_party/heimdal/lib/krb5/krb5_locl.h

index 7045c5bb60165b009d90e3dc96e734d63ac24556..91751c1baba6622598a30c84ee3c3839d46efc73 100644 (file)
@@ -204,10 +204,6 @@ extern const char _krb5_wellknown_lkdc[];
 #define ALLOC(X, N) (X) = calloc((N), sizeof(*(X)))
 #define ALLOC_SEQ(X, N) do { (X)->len = (N); ALLOC((X)->val, (N)); } while(0)
 
-#ifndef __func__
-#define __func__ "unknown-function"
-#endif
-
 #define krb5_einval(context, argnum) _krb5_einval((context), __func__, (argnum))
 
 #ifndef PATH_SEP