]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe: Mark ROW_CHICKEN5 as a masked register
authorMatt Roper <matthew.d.roper@intel.com>
Fri, 10 Apr 2026 22:50:30 +0000 (15:50 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Mon, 13 Apr 2026 19:41:56 +0000 (12:41 -0700)
ROW_CHICKEN5 is a masked register (i.e., to adjust the value of any of
the lower 16 bits, the corresponding bit in the upper 16 bits must also
be set).  Add the XE_REG_OPTION_MASKED to its definition; failure to do
so will cause workaround updates of this register to not apply properly.

Bspec: 56853
Fixes: 835cd6cbb0d0 ("drm/xe/xe3p_lpg: Add initial workarounds for graphics version 35.10")
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://patch.msgid.link/20260410-xe3p_tuning-v1-3-e206a62ee38f@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
drivers/gpu/drm/xe/regs/xe_gt_regs.h

index aa267c2f6162602c6c922e061139391914297ddd..a4472b7acb18ae4ca0d348bd67bf826b4337f198 100644 (file)
 #define   DISABLE_128B_EVICTION_COMMAND_UDW    REG_BIT(36 - 32)
 #define   LSCFE_SAME_ADDRESS_ATOMICS_COALESCING_DISABLE        REG_BIT(35 - 32)
 
-#define ROW_CHICKEN5                           XE_REG_MCR(0xe7f0)
+#define ROW_CHICKEN5                           XE_REG_MCR(0xe7f0, XE_REG_OPTION_MASKED)
 #define   CPSS_AWARE_DIS                       REG_BIT(3)
 
 #define SARB_CHICKEN1                          XE_REG_MCR(0xe90c)