]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: lt9611: switch to of_drm_get_bridge_by_endpoint()
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Mon, 11 May 2026 16:40:11 +0000 (18:40 +0200)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 19 May 2026 08:57:26 +0000 (10:57 +0200)
This driver calls drm_of_find_panel_or_bridge() with a NULL pointer in the
@panel parameter, thus using a reduced feature set of that function.
Replace this call with the simpler of_drm_get_bridge_by_endpoint().

Since of_drm_get_bridge_by_endpoint() increases the refcount of the
returned bridge, ensure it is put on removal. To achieve this, instead of
adding an explicit drm_bridge_put(), migrate to the bridge::next_bridge
pointer which is automatically put when the bridge is eventually freed.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-7-f61c9e498b3f@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/lontium-lt9611.c

index 0f49b13193b930d3a75a2d3cfaf8cf9ed92ee360..21305296e1117813c4a7d3e6c3997ffd168f8000 100644 (file)
@@ -37,7 +37,6 @@
 struct lt9611 {
        struct device *dev;
        struct drm_bridge bridge;
-       struct drm_bridge *next_bridge;
 
        struct regmap *regmap;
 
@@ -761,7 +760,7 @@ static int lt9611_bridge_attach(struct drm_bridge *bridge,
 {
        struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
 
-       return drm_bridge_attach(encoder, lt9611->next_bridge,
+       return drm_bridge_attach(encoder, lt9611->bridge.next_bridge,
                                 bridge, flags);
 }
 
@@ -1058,7 +1057,11 @@ static int lt9611_parse_dt(struct device *dev,
 
        lt9611->ac_mode = of_property_read_bool(dev->of_node, "lt,ac-mode");
 
-       return drm_of_find_panel_or_bridge(dev->of_node, 2, -1, NULL, &lt9611->next_bridge);
+       lt9611->bridge.next_bridge = of_drm_get_bridge_by_endpoint(dev->of_node, 2, -1);
+       if (IS_ERR(lt9611->bridge.next_bridge))
+               return PTR_ERR(lt9611->bridge.next_bridge);
+
+       return 0;
 }
 
 static int lt9611_gpio_init(struct lt9611 *lt9611)