]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/wm: Reorder the arguments to skl_allocate_plane_ddb()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 19 Mar 2026 11:40:27 +0000 (13:40 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Sat, 21 Mar 2026 08:15:59 +0000 (10:15 +0200)
Group the ddb and data_rate together in the skl_allocate_plane_ddb()
arguments. Upcoming changes will adjust the UV plane handling and
keeing the ddb allocation and the data rate used to calculate it
together will help with clarity.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260319114034.7093-3-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/skl_watermark.c

index 0f99a3264f057888d89428487b1cb08e48386d6e..1664b84d03871735ede9bbde7a5e125e4e9d609d 100644 (file)
@@ -1391,9 +1391,8 @@ struct skl_plane_ddb_iter {
 
 static void
 skl_allocate_plane_ddb(struct skl_plane_ddb_iter *iter,
-                      struct skl_ddb_entry *ddb,
                       const struct skl_wm_level *wm,
-                      u64 data_rate)
+                      struct skl_ddb_entry *ddb, u64 data_rate)
 {
        u16 size, extra = 0;
 
@@ -1523,13 +1522,13 @@ skl_crtc_allocate_plane_ddb(struct intel_atomic_state *state,
 
                if (DISPLAY_VER(display) < 11 &&
                    crtc_state->nv12_planes & BIT(plane_id)) {
-                       skl_allocate_plane_ddb(&iter, ddb_y, &wm->wm[level],
-                                              crtc_state->rel_data_rate_y[plane_id]);
-                       skl_allocate_plane_ddb(&iter, ddb, &wm->uv_wm[level],
-                                              crtc_state->rel_data_rate[plane_id]);
+                       skl_allocate_plane_ddb(&iter, &wm->wm[level],
+                                              ddb_y, crtc_state->rel_data_rate_y[plane_id]);
+                       skl_allocate_plane_ddb(&iter, &wm->uv_wm[level],
+                                              ddb, crtc_state->rel_data_rate[plane_id]);
                } else {
-                       skl_allocate_plane_ddb(&iter, ddb, &wm->wm[level],
-                                              crtc_state->rel_data_rate[plane_id]);
+                       skl_allocate_plane_ddb(&iter, &wm->wm[level],
+                                              ddb, crtc_state->rel_data_rate[plane_id]);
                }
 
                if (DISPLAY_VER(display) >= 30) {