OpenMP: Fix omp_get_device_from_uid, minor cleanup

In Fortran, omp_get_device_from_uid can also accept substrings, which are
then not NUL terminated.  Fixed by introducing a fortran.c wrapper function.
Additionally, in case of a fail the plugin functions now return NULL instead
of failing fatally such that a fall-back UID is generated.

gcc/ChangeLog:

	* omp-general.cc (omp_runtime_api_procname): Strip "omp_" from
	string; move get_device_from_uid as now a '_' suffix exists.

libgomp/ChangeLog:

	* fortran.c (omp_get_device_from_uid_): New function.
	* libgomp.map (GOMP_6.0): Add it.
	* oacc-host.c (host_dispatch): Init '.uid' and '.get_uid_func'.
	* omp_lib.f90.in: Make it used by removing bind(C).
	* omp_lib.h.in: Likewise.
	* target.c (omp_get_device_from_uid): Ensure the device is initialized.
	* plugin/plugin-gcn.c (GOMP_OFFLOAD_get_uid): Add function comment;
	return NULL in case of an error.
	* plugin/plugin-nvptx.c (GOMP_OFFLOAD_get_uid): Likewise.
	* testsuite/libgomp.fortran/device_uid.f90: Update to test substrings.

diff --git a/gcc/omp-general.cc b/gcc/omp-general.cc
index 12788ad02490b6bd6304d86ae01c62e79b67bec6..3dfbc315056fe198c3e9827057a928e55a2176cf 100644 (file)
--- a/gcc/omp-general.cc
+++ b/gcc/omp-general.cc
@@ -3260,7 +3260,6 @@ omp_runtime_api_procname (const char *name)
       "alloc",
       "calloc",
       "free",
-      "get_device_from_uid",
       "get_interop_int",
       "get_interop_ptr",
       "get_mapped_ptr",
@@ -3290,6 +3289,7 @@ omp_runtime_api_procname (const char *name)
       "get_cancellation",
       "get_default_allocator",
       "get_default_device",
+      "get_device_from_uid",
       "get_device_num",
       "get_dynamic",
       "get_initial_device",
@@ -3339,7 +3339,7 @@ omp_runtime_api_procname (const char *name)
         as DECL_NAME only omp_* and omp_*_8 appear.  */
       "display_env",
       "get_ancestor_thread_num",
-      "omp_get_uid_from_device",
+      "get_uid_from_device",
       "get_partition_place_nums",
       "get_place_num_procs",
       "get_place_proc_ids",

diff --git a/libgomp/fortran.c b/libgomp/fortran.c
index 9b7f093555b087e619830789051002145e1c163d..7976e5b9638d1927581556c1f42e5082b33edbab 100644 (file)
--- a/libgomp/fortran.c
+++ b/libgomp/fortran.c
@@ -834,6 +834,24 @@ omp_get_interop_rc_desc_ (const char **res, size_t *res_len,
   *res_len = *res ? strlen (*res) : 0;
 }
 
+int
+omp_get_device_from_uid_ (const char *uid, size_t uid_len)
+{
+#ifndef LIBGOMP_OFFLOADED_ONLY
+  char *str = __builtin_alloca ((uid_len + 1) * sizeof (char));
+  memcpy (str, uid, uid_len * sizeof (char));
+  str[uid_len] = '\0';
+  return omp_get_device_from_uid (str);
+#else
+  /* Inside the target region, invoking this routine is undefined
+     behavior; thus, resolve it already here - instead of inside
+     libgomp/config/.../target.c.
+     Note that on nvptx __builtin_alloca is defined, but fails with a sorry
+     during compilation, as it is unsupported until isa 7.3 / sm_52.  */
+  return omp_invalid_device;
+#endif
+}
+
 void
 omp_get_uid_from_device_ (const char **res, size_t *res_len,
                          int32_t device_num)

diff --git a/libgomp/libgomp.map b/libgomp/libgomp.map
index 0023d3e1b6de8195d8edd6aaf75fab799d594bb5..4530b3adc94e76706f80511b6228154d0155bfcd 100644 (file)
--- a/libgomp/libgomp.map
+++ b/libgomp/libgomp.map
@@ -446,6 +446,7 @@ GOMP_5.1.3 {
 GOMP_6.0 {
   global:
        omp_get_device_from_uid;
+       omp_get_device_from_uid_;
        omp_get_uid_from_device;
        omp_get_uid_from_device_;
        omp_get_uid_from_device_8_;

diff --git a/libgomp/oacc-host.c b/libgomp/oacc-host.c
index 5efdf7fb7968896ad5d5661b9145e76a0b9573c8..7d4362ebd6ce1461154897bbb91db1d6c23cecf3 100644 (file)
--- a/libgomp/oacc-host.c
+++ b/libgomp/oacc-host.c
@@ -263,6 +263,7 @@ host_openacc_destroy_thread_data (void *tls_data __attribute__ ((unused)))
 static struct gomp_device_descr host_dispatch =
   {
     .name = "host",
+    .uid = NULL,
     .capabilities = (GOMP_OFFLOAD_CAP_SHARED_MEM
                     | GOMP_OFFLOAD_CAP_NATIVE_EXEC
                     | GOMP_OFFLOAD_CAP_OPENACC_200),
@@ -270,6 +271,7 @@ static struct gomp_device_descr host_dispatch =
     .type = OFFLOAD_TARGET_TYPE_HOST,
 
     .get_name_func = host_get_name,
+    .get_uid_func = NULL,
     .get_caps_func = host_get_caps,
     .get_type_func = host_get_type,
     .get_num_devices_func = host_get_num_devices,

diff --git a/libgomp/omp_lib.f90.in b/libgomp/omp_lib.f90.in
index 360352c5a073a92a6779b22c00ab058ce9d71039..77f2bd4d38e6ec886761f02286b5d4fb00e46d6f 100644 (file)
--- a/libgomp/omp_lib.f90.in
+++ b/libgomp/omp_lib.f90.in
@@ -1004,10 +1004,9 @@
         end interface
 
         interface
-          ! Note: In gfortran, strings are \0 termined
-          integer(c_int) function omp_get_device_from_uid(uid) bind(C)
+          integer(c_int) function omp_get_device_from_uid (uid)
             use iso_c_binding
-            character(c_char), intent(in) :: uid(*)
+            character, intent(in) :: uid(*)
           end function omp_get_device_from_uid
         end interface
 

diff --git a/libgomp/omp_lib.h.in b/libgomp/omp_lib.h.in
index 10038611d80110443c09ee4ec6c118fc4fceef45..fcfc737243c200ae95545084c882d98d456702ad 100644 (file)
--- a/libgomp/omp_lib.h.in
+++ b/libgomp/omp_lib.h.in
@@ -612,10 +612,9 @@
       end interface
 
       interface
-!       Note: In gfortran, strings are \0 termined
-        integer(c_int) function omp_get_device_from_uid(uid) bind(C)
+        integer(c_int) function omp_get_device_from_uid (uid)
           use iso_c_binding
-          character(c_char), intent(in) :: uid(*)
+          character, intent(in) :: uid(*)
         end function omp_get_device_from_uid
       end interface
 

diff --git a/libgomp/plugin/plugin-gcn.c b/libgomp/plugin/plugin-gcn.c
index bf6ad371ea201073aa39bc284c91e0c5385053e2..f805206852dc5041a24c1ab13f226078efac0c27 100644 (file)
--- a/libgomp/plugin/plugin-gcn.c
+++ b/libgomp/plugin/plugin-gcn.c
@@ -3316,6 +3316,9 @@ GOMP_OFFLOAD_get_name (void)
   return "gcn";
 }
 
+/* Return the UID; if not available return NULL.
+   Returns freshly allocated memoy.  */
+
 const char *
 GOMP_OFFLOAD_get_uid (int ord)
 {
@@ -3328,7 +3331,10 @@ GOMP_OFFLOAD_get_uid (int ord)
   status = hsa_fns.hsa_agent_get_info_fn (agent->id, HSA_AMD_AGENT_INFO_UUID,
                                          str);
   if (status != HSA_STATUS_SUCCESS)
-    hsa_fatal ("Could not obtain device UUID", status);
+    {
+      free (str);
+      return NULL;
+    }
   return str;
 }
 

diff --git a/libgomp/plugin/plugin-nvptx.c b/libgomp/plugin/plugin-nvptx.c
index a8b85bd9fd00aa3d1f7da054a8df2890feaf7b06..9310241d4fb925f880729d5c0b079ba6c7ff5588 100644 (file)
--- a/libgomp/plugin/plugin-nvptx.c
+++ b/libgomp/plugin/plugin-nvptx.c
@@ -1242,6 +1242,9 @@ GOMP_OFFLOAD_get_name (void)
   return "nvptx";
 }
 
+/* Return the UID; if not available return NULL.
+   Returns freshly allocated memoy.  */
+
 const char *
 GOMP_OFFLOAD_get_uid (int ord)
 {
@@ -1254,9 +1257,9 @@ GOMP_OFFLOAD_get_uid (int ord)
   else if (CUDA_CALL_EXISTS (cuDeviceGetUuid))
     r = CUDA_CALL_NOCHECK (cuDeviceGetUuid, &s, dev->dev);
   else
-    r = CUDA_ERROR_NOT_FOUND;
+    return NULL;
   if (r != CUDA_SUCCESS)
-    GOMP_PLUGIN_fatal ("cuDeviceGetUuid error: %s", cuda_error (r));
+    NULL;
 
   size_t len = strlen ("GPU-12345678-9abc-defg-hijk-lmniopqrstuv");
   char *str = (char *) GOMP_PLUGIN_malloc (len + 1);

diff --git a/libgomp/target.c b/libgomp/target.c
index f9aa1789f0b8fb642a57e46735bc9d2c0bf10c85..abd1ac8bcca9e68d4251546c41e0b10fbba6d612 100644 (file)
--- a/libgomp/target.c
+++ b/libgomp/target.c
@@ -5268,8 +5268,11 @@ omp_get_device_from_uid (const char *uid)
   if (strcmp (uid, str_omp_initial_device) == 0)
     return omp_initial_device;
   for (int dev = 0; dev < gomp_get_num_devices (); dev++)
-    if (strcmp (uid, gomp_get_uid_for_device (&devices[dev], dev)) == 0)
-      return dev;
+    {
+      struct gomp_device_descr *devicep = resolve_device (dev, false);
+      if (strcmp (uid, gomp_get_uid_for_device (devicep, dev)) == 0)
+       return dev;
+    }
   return omp_invalid_device;
 }
 

diff --git a/libgomp/testsuite/libgomp.fortran/device_uid.f90 b/libgomp/testsuite/libgomp.fortran/device_uid.f90
index 4c2a28a104e21e371af1915ac884e136d50260e2..504f6caaf07dc6d858caccb88f0004cfb57b945d 100644 (file)
--- a/libgomp/testsuite/libgomp.fortran/device_uid.f90
+++ b/libgomp/testsuite/libgomp.fortran/device_uid.f90
@@ -12,7 +12,7 @@ program main
 
   do i = omp_invalid_device - 1, omp_get_num_devices () + 1
     str => omp_get_uid_from_device (i)
-    dev = omp_get_device_from_uid (str);
+    dev = omp_get_device_from_uid (str)
 ! print *, i, str, dev
     if (i < omp_initial_device .or. i > omp_get_num_devices ()) then
       if (dev /= omp_invalid_device .or. associated(str)) &
@@ -30,12 +30,26 @@ program main
       stop 4
     end if
     strs(dev)%str => str
+
+    block
+      ! Check substring handling
+      character(len=100) :: long_str
+      integer :: dev2
+      long_str = str // "ABCDEF"
+      dev2 = omp_get_device_from_uid (long_str(1:len(str)))
+      if (i == omp_initial_device .or. i == omp_get_num_devices ()) then
+        if (dev2 /= omp_initial_device .and. dev2  /= omp_get_num_devices ()) &
+          stop 5
+      else if (dev /= dev2) then
+        stop 6
+      end if
+    end block
   end do
 
   do i = 0, omp_get_num_devices () - 1
     do j = i + 1, omp_get_num_devices ()
       if (strs(i)%str == strs(j)%str) &
-        stop 4
+        stop 7
     end do
   end do
   deallocate (strs)