]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:libcli: remove unused ports from smbcli_socket_connect()
authorStefan Metzmacher <metze@samba.org>
Thu, 3 Apr 2025 08:40:51 +0000 (10:40 +0200)
committerStefan Metzmacher <metze@samba.org>
Fri, 18 Apr 2025 10:17:29 +0000 (10:17 +0000)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
source4/client/client.c
source4/libcli/cliconnect.c
source4/libcli/libcli.h
source4/torture/basic/base.c

index 8debb61c6ff8bd2b541cd221bb99ecb707736b8d..2b96049bb91d9b9fde7ff46084dcfe2805aa9415 100644 (file)
@@ -3277,7 +3277,7 @@ static int do_message_op(const char *netbios_name, const char *desthost,
                return 1;
        }
 
-       ok = smbcli_socket_connect(cli, server_name, destports,
+       ok = smbcli_socket_connect(cli, server_name,
                                   ev_ctx, resolve_ctx, options,
                                   socket_options,
                                   &calling, &called);
index 9da2f5e7f8d27b2f7b1298a5cd3e32abe1b2fce8..f9fb18d9faa3f5c72bdb5eb3da710eaa3c48c6e4 100644 (file)
@@ -32,7 +32,6 @@
   wrapper around smbcli_sock_connect()
 */
 bool smbcli_socket_connect(struct smbcli_state *cli, const char *server, 
-                          const char **ports, 
                           struct tevent_context *ev_ctx,
                           struct resolve_context *resolve_ctx,
                           struct smbcli_options *options,
index 9d2a32404834cb3703e9e9f3ca016df343335948..27b7c36370e3d1ef4fe71e1f708f59f5cca92905 100644 (file)
@@ -87,7 +87,6 @@ ssize_t smbcli_smbwrite(struct smbcli_tree *tree,
                     int fnum, const void *_buf, off_t offset, size_t size1);
 
 bool smbcli_socket_connect(struct smbcli_state *cli, const char *server, 
-                          const char **ports, 
                           struct tevent_context *ev_ctx,
                           struct resolve_context *resolve_ctx,
                           struct smbcli_options *options,
index fc36e6b441dd75b08fdde7b0038d93da9ff1b4f5..8baecf4553913254d355392f60f8c479abcb89fd 100644 (file)
@@ -54,7 +54,7 @@ static struct smbcli_state *open_nbt_connection(struct torture_context *tctx)
 
        lpcfg_smbcli_options(tctx->lp_ctx, &options);
 
-       ok = smbcli_socket_connect(cli, host, lpcfg_smb_ports(tctx->lp_ctx),
+       ok = smbcli_socket_connect(cli, host,
                                   tctx->ev,
                                   lpcfg_resolve_context(tctx->lp_ctx),
                                   &options,