Bug 302200: uninitialized value when saving email prefs - Patch by Rob Siklos <robzil...

diff --git a/userprefs.cgi b/userprefs.cgi
index 5f52a3ca72648e6ea1c317f54032f5fb95e60254..12a05d26f93b671dffe006a93ba29ef958fbac5e 100755 (executable)
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -253,7 +253,9 @@ sub SaveEmail {
 
     # Global positive events: a ticked box means "send me mail."
     foreach my $event (GLOBAL_EVENTS) {
-        if (1 == $cgi->param("email-" . REL_ANY . "-$event")) {
+        if (defined($cgi->param("email-" . REL_ANY . "-$event"))
+            && $cgi->param("email-" . REL_ANY . "-$event") == 1)
+        {
             $dbh->do("INSERT INTO email_setting " . 
                      "(user_id, relationship, event) " . 
                      "VALUES ($userid, " . REL_ANY . ", $event)");