]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: report PCS link changes to phylink
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sun, 11 Jan 2026 13:15:29 +0000 (13:15 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 13 Jan 2026 03:36:49 +0000 (19:36 -0800)
Report PCS link changes to phylink, which will allow phylink's inband
support to respoind to link events once the PCS is appropriately
configured.

An expected behavioural change is that should the PCS report that its
link has failed, but phylink is operating in outband mode and the PHY
reports that link is up, this event will cause the netdev's link to
momentarily drop, making the event more noticable, rather than just
producing a "stmmac_pcs: Link Down" message.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vevI1-00000002Yp8-3cM3@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c

index 28748e7ef7dd108b39d10760b4a83f5ea8fb943c..2f826fe7229b6470312170b8ff9f17c65ff1b3e5 100644 (file)
@@ -62,6 +62,8 @@ void stmmac_integrated_pcs_irq(struct stmmac_priv *priv, u32 status,
                x->irq_pcs_link_n++;
                dev_info(priv->device, "PCS Link %s\n",
                         val & GMAC_AN_STATUS_LS ? "Up" : "Down");
+
+               phylink_pcs_change(&spcs->pcs, val & GMAC_AN_STATUS_LS);
        }
 }