]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[i386] Add explicit ""aw", @nobits" declarations to stack sections
authorMichael Brown <mcb30@etherboot.org>
Sun, 15 Feb 2009 10:02:26 +0000 (10:02 +0000)
committerMichael Brown <mcb30@etherboot.org>
Sun, 15 Feb 2009 10:02:26 +0000 (10:02 +0000)
As reported by Stefan, commit 13d09e6 ("[i386] Simplify linker script
and standardise linker-defined symbol names") breaks gdb, readelf and
associated utilities.

This is caused by the .stack section overwriting a block in the middle
of the .debug_info section (despite being included in the
.bss.textdata section in the output file, which apparently has the
correct attributes for a .bss section).

Fixed by adding explicit flags and type to the stack section
declaration.

src/arch/i386/core/stack.S
src/arch/i386/core/stack16.S

index c2d138aaff3e1dad77104225cd5ecb0b72c4be48..da66d23954b780b2fd382161c1848b11fce8bd27 100644 (file)
@@ -4,7 +4,7 @@
  * Internal stack
  ****************************************************************************
  */
-       .section ".stack"
+       .section ".stack", "aw", @nobits
        .align 8
        .globl _stack
 _stack:
index 3380a08360fb1dcdf9172dc3c51b650007378593..d1251f06b19bcacbc9a45f9ae6e11ca736470743 100644 (file)
@@ -4,7 +4,7 @@
  * Internal stack
  ****************************************************************************
  */
-       .section ".stack16"
+       .section ".stack16", "aw", @nobits
        .align 8
        .globl _stack16
 _stack16: