]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
PR fortran/93423 - ICE on invalid with argument list for module procedure
authorHarald Anlauf <anlauf@gmx.de>
Thu, 2 Jul 2020 18:48:16 +0000 (20:48 +0200)
committerHarald Anlauf <anlauf@gmx.de>
Fri, 18 Sep 2020 20:17:35 +0000 (22:17 +0200)
When recovering from an error, a NULL pointer dereference could occur.
Check for that situation and punt.

gcc/fortran/
PR fortran/93423
* resolve.c (resolve_symbol): Avoid NULL pointer dereference.

(cherry picked from commit b88744905a46be44ffa3c57d46080f601ae832b8)

gcc/fortran/resolve.c
gcc/testsuite/gfortran.dg/pr93423.f90 [new file with mode: 0644]

index c650096df6d6c96374b7e80eb9437f2e6a8db046..ce86d4822f58cfa07dfb1eb0f32abb81ba130d2e 100644 (file)
@@ -15929,7 +15929,7 @@ resolve_symbol (gfc_symbol *sym)
       if (formal)
        {
          sym->formal_ns = formal->sym->ns;
-          if (sym->ns != formal->sym->ns)
+         if (sym->formal_ns && sym->ns != formal->sym->ns)
            sym->formal_ns->refs++;
        }
     }
diff --git a/gcc/testsuite/gfortran.dg/pr93423.f90 b/gcc/testsuite/gfortran.dg/pr93423.f90
new file mode 100644 (file)
index 0000000..fed5914
--- /dev/null
@@ -0,0 +1,21 @@
+! { dg-do compile }
+! PR fortran/93423 - ICE on invalid with argument list for module procedure
+
+module t
+  type :: b
+   contains
+     procedure :: p => bp
+  end type b
+  interface
+     module function bp(s)
+       class(b), intent(inout) :: s
+       integer, pointer :: bp
+     end function
+  end interface
+end module t
+
+submodule (t) ts
+contains
+  module procedure bp(s) ! { dg-error "must be in a generic module interface" }
+  end procedure bp       ! { dg-error "Expecting END SUBMODULE statement" }
+end submodule ts