]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli/security: Make use of sids_contains_sid_attrs()
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 30 Oct 2023 01:35:12 +0000 (14:35 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 1 Nov 2023 20:10:45 +0000 (20:10 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/security/util_sid.c

index 33886e788f70aaaf144ca982125f7712d38cd908..b3408b37a4690942b857ba8aaa84363d4f4d235c 100644 (file)
@@ -444,16 +444,10 @@ NTSTATUS add_sid_to_array_attrs_unique(TALLOC_CTX *mem_ctx,
                                       const struct dom_sid *sid, uint32_t attrs,
                                       struct auth_SidAttr **sids, uint32_t *num_sids)
 {
-       uint32_t i;
-
-       for (i=0; i<(*num_sids); i++) {
-               if (attrs != (*sids)[i].attrs) {
-                       continue;
-               }
-               if (!dom_sid_equal(sid, &(*sids)[i].sid)) {
-                       continue;
-               }
+       bool contains;
 
+       contains = sids_contains_sid_attrs(*sids, *num_sids, sid, attrs);
+       if (contains) {
                return NT_STATUS_OK;
        }