]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuSnapshotFSFreeze: Don't return -2
authorPeter Krempa <pkrempa@redhat.com>
Mon, 15 Feb 2021 17:12:29 +0000 (18:12 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 16 Feb 2021 11:25:30 +0000 (12:25 +0100)
The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
doesn't necessarily mean that the command was sent to the agent.

Since callers don't care about the -2 value specifically, remove it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/qemu/qemu_snapshot.c

index eacc8c6400c6d877abe87a781535ae979d105673..93b74b035a7c68c3a05b1416b29e757d719a54ec 100644 (file)
@@ -119,9 +119,6 @@ qemuSnapshotCountExternal(void *payload,
 }
 
 
-/* Return -1 if request is not sent to agent due to misconfig, -2 if request
- * is sent but failed, and number of frozen filesystems on success. If -2 is
- * returned, FSThaw should be called revert the quiesced status. */
 int
 qemuSnapshotFSFreeze(virDomainObjPtr vm,
                      const char **mountpoints,
@@ -136,7 +133,7 @@ qemuSnapshotFSFreeze(virDomainObjPtr vm,
     agent = qemuDomainObjEnterAgent(vm);
     frozen = qemuAgentFSFreeze(agent, mountpoints, nmountpoints);
     qemuDomainObjExitAgent(vm, agent);
-    return frozen < 0 ? -2 : frozen;
+    return frozen;
 }