]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect-fast-pattern: Mark as OPTIONAL_OPT, instead of NOOPT
authorGianni Tedesco <gianni@scaramanga.co.uk>
Sun, 13 Dec 2020 14:50:23 +0000 (23:50 +0900)
committerVictor Julien <victor@inliniac.net>
Wed, 30 Dec 2020 14:50:17 +0000 (15:50 +0100)
Also update the erroneous comment about it.

src/detect-fast-pattern.c

index 0a3d0d1fc146516829fdfeeba3943ae51d41f712..408aafe4b6afdd35e79d517f5c1a0376eefd0840 100644 (file)
@@ -175,7 +175,7 @@ void DetectFastPatternRegister(void)
 #ifdef UNITTESTS
     sigmatch_table[DETECT_FAST_PATTERN].RegisterTests = DetectFastPatternRegisterTests;
 #endif
-    sigmatch_table[DETECT_FAST_PATTERN].flags |= SIGMATCH_NOOPT;
+    sigmatch_table[DETECT_FAST_PATTERN].flags |= SIGMATCH_OPTIONAL_OPT;
 
     DetectSetupParseRegexes(PARSE_REGEX, &parse_regex);
 }
@@ -188,7 +188,7 @@ void DetectFastPatternRegister(void)
  *
  * \param de_ctx   Pointer to the Detection Engine Context.
  * \param s        Pointer to the Signature to which the current keyword belongs.
- * \param null_str Should hold an empty string always.
+ * \param arg      May hold an argument
  *
  * \retval  0 On success.
  * \retval -1 On failure.