Fix a warning thrown in the web server error log (due to bug 454251)

diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm
index 33c761cf1581fe33977bf486f668c00535d607d0..9748d17f46bb552a8b953914594e54791a11aca0 100644 (file)
--- a/Bugzilla/Attachment.pm
+++ b/Bugzilla/Attachment.pm
@@ -613,12 +613,13 @@ sub _check_filename {
 sub _check_is_private {
     my ($invocant, $is_private) = @_;
 
+    $is_private = $is_private ? 1 : 0;
     if (((!ref $invocant && $is_private)
          || (ref $invocant && $invocant->isprivate != $is_private))
         && !Bugzilla->user->is_insider) {
         ThrowUserError('user_not_insider');
     }
-    return $is_private ? 1 : 0;
+    return $is_private;
 }
 
 sub _check_is_url {