]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: remove out label in btrfs_check_rw_degradable()
authorFilipe Manana <fdmanana@suse.com>
Tue, 20 Jan 2026 20:06:20 +0000 (20:06 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 3 Feb 2026 06:56:23 +0000 (07:56 +0100)
There is no point in having the label since all it does is return the
value in the 'ret' variable. Instead make every goto return directly
and remove the label.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c

index af0197b242a7d385067d899e013b20b91f6ba4e5..cff2412bc879daa6d013e71b5f379e1535ef390c 100644 (file)
@@ -7576,10 +7576,9 @@ bool btrfs_check_rw_degradable(struct btrfs_fs_info *fs_info,
 
        map = btrfs_find_chunk_map(fs_info, 0, U64_MAX);
        /* No chunk at all? Return false anyway */
-       if (!map) {
-               ret = false;
-               goto out;
-       }
+       if (!map)
+               return false;
+
        while (map) {
                int missing = 0;
                int max_tolerated;
@@ -7604,15 +7603,14 @@ bool btrfs_check_rw_degradable(struct btrfs_fs_info *fs_info,
        "chunk %llu missing %d devices, max tolerance is %d for writable mount",
                                   map->start, missing, max_tolerated);
                        btrfs_free_chunk_map(map);
-                       ret = false;
-                       goto out;
+                       return false;
                }
                next_start = map->start + map->chunk_len;
                btrfs_free_chunk_map(map);
 
                map = btrfs_find_chunk_map(fs_info, next_start, U64_MAX - next_start);
        }
-out:
+
        return ret;
 }