]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: core: move constants to right side in comparison
authorWilliam Hansen-Baird <william.hansen.baird@gmail.com>
Wed, 24 Dec 2025 10:02:56 +0000 (05:02 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Jan 2026 12:51:59 +0000 (13:51 +0100)
Move constants to right side in if-statement conditions.

Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com>
Link: https://patch.msgid.link/20251224100329.762141-3-william.hansen.baird@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_ieee80211.c
drivers/staging/rtl8723bs/core/rtw_security.c

index 8fdeeda88a6dc4ff31f7ae59e3a87bb34138ac72..92b12a13d27cf3926aef2d3cfe98143ad82f8e07 100644 (file)
@@ -1009,7 +1009,7 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork)
        pbuf = rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork->network.ie_length-12);
 
        if (pbuf && (wpa_ielen > 0)) {
-               if (_SUCCESS == rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x)) {
+               if (rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x) == _SUCCESS) {
                        pnetwork->bcn_info.pairwise_cipher = pairwise_cipher;
                        pnetwork->bcn_info.group_cipher = group_cipher;
                        pnetwork->bcn_info.is_8021x = is8021x;
@@ -1019,7 +1019,7 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork)
                pbuf = rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork->network.ie_length-12);
 
                if (pbuf && (wpa_ielen > 0)) {
-                       if (_SUCCESS == rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x)) {
+                       if (rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x) == _SUCCESS) {
                                pnetwork->bcn_info.pairwise_cipher = pairwise_cipher;
                                pnetwork->bcn_info.group_cipher = group_cipher;
                                pnetwork->bcn_info.is_8021x = is8021x;
index 2f941ffbd465122965e4c00e0f61d58b4df393ac..86e54454145a288e0bf4e99ae93caacd3ff2f06f 100644 (file)
@@ -1488,7 +1488,7 @@ void rtw_sec_restore_wep_key(struct adapter *adapter)
        struct security_priv *securitypriv = &(adapter->securitypriv);
        signed int keyid;
 
-       if ((_WEP40_ == securitypriv->dot11PrivacyAlgrthm) || (_WEP104_ == securitypriv->dot11PrivacyAlgrthm)) {
+       if ((securitypriv->dot11PrivacyAlgrthm == _WEP40_) || (securitypriv->dot11PrivacyAlgrthm == _WEP104_)) {
                for (keyid = 0; keyid < 4; keyid++) {
                        if (securitypriv->key_mask & BIT(keyid)) {
                                if (keyid == securitypriv->dot11PrivacyKeyIndex)