]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Message.c: Clear message channel frames on cleanup 70/470/1
authorJonathan Rose <jrose@digium.com>
Wed, 13 May 2015 20:41:07 +0000 (15:41 -0500)
committerJonathan Rose <jrose@digium.com>
Thu, 14 May 2015 16:24:17 +0000 (11:24 -0500)
The message channel is a special channel that doesn't actually process frames.
However, certain actions can cause frames to be placed in the channel's read
queue including the Hangup application which is called on the channel after
each message is processed. Since the channel will continually be reused for
many messages, it's necessary to flush these frames at some point.

ASTERISK-25083 #close
Reported by: Jonathan Rose

Change-Id: Idf18df73ccd8c220be38743335b5c79c2a4c0d0f

main/message.c

index a3a86b3808e7937ac5f501c1c8857016c5bb8535..0a43667d3e5b11e446c36b19cfa6c8af4abb9fa5 100644 (file)
@@ -728,6 +728,7 @@ static void chan_cleanup(struct ast_channel *chan)
        struct ast_datastore *msg_ds, *ds;
        struct varshead *headp;
        struct ast_var_t *vardata;
+       struct ast_frame *cur;
 
        ast_channel_lock(chan);
 
@@ -756,6 +757,13 @@ static void chan_cleanup(struct ast_channel *chan)
                ast_var_delete(vardata);
        }
 
+       /*
+        * Remove frames from read queue
+        */
+       while ((cur = AST_LIST_REMOVE_HEAD(ast_channel_readq(chan), frame_list))) {
+               ast_frfree(cur);
+       }
+
        /*
         * Restore msg datastore.
         */