]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
copy_tree(): don't set ->mnt_mountpoint on the root of copy
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 1 Jun 2025 04:34:32 +0000 (00:34 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 29 Jun 2025 22:13:41 +0000 (18:13 -0400)
It never made any sense - neither when copy_tree() had been introduced
(2.4.11-pre5), nor at any point afterwards.  Mountpoint is meaningless
without parent mount and the root of copied tree has no parent until we get
around to attaching it somewhere.  At that time we'll have mountpoint set;
before that we have no idea which dentry will be used as mountpoint.
IOW, copy_tree() should just leave the default value.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namespace.c

index 9b732d74c2cc7ba1b5df41ebfffebee6fa9453e8..f0a56dbceff907d2c79fed30010b3808df55d0c6 100644 (file)
@@ -2222,7 +2222,6 @@ struct mount *copy_tree(struct mount *src_root, struct dentry *dentry,
                return dst_mnt;
 
        src_parent = src_root;
-       dst_mnt->mnt_mountpoint = src_root->mnt_mountpoint;
 
        list_for_each_entry(src_root_child, &src_root->mnt_mounts, mnt_child) {
                if (!is_subdir(src_root_child->mnt_mountpoint, dentry))