Bug 300006: "cookies need value" error code when a query returns an empty result.

Patch By Marc Schumann <wurblzap@gmail.com> r=glob, a=justdave

diff --git a/buglist.cgi b/buglist.cgi
index edacd836e3c7e27c5d2b74dc8ecdc42d4e7000f1..4768843de3ae33f5ee5bc15597963768df0b3f08 100755 (executable)
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -1013,7 +1013,10 @@ if ($format->{'extension'} eq "html") {
     }
     my $bugids = join(":", @bugidlist);
     # See also Bug 111999
-    if (length($bugids) < 4000) {
+    if (length($bugids) == 0) {
+        $cgi->remove_cookie('BUGLIST');
+    }
+    elsif (length($bugids) < 4000) {
         $cgi->send_cookie(-name => 'BUGLIST',
                           -value => $bugids,
                           -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');

diff --git a/colchange.cgi b/colchange.cgi
index 235da6a01b94061cefddfddeba9d6c9a1ffb3d19..30103406fd33553af04b8ecfbf3759379bdddbc3 100755 (executable)
--- a/colchange.cgi
+++ b/colchange.cgi
@@ -103,9 +103,14 @@ if (defined $cgi->param('rememberedquery')) {
     my $list = join(" ", @collist);
     my $urlbase = Param("urlbase");
 
-    $cgi->send_cookie(-name => 'COLUMNLIST',
-                      -value => $list,
-                      -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
+    if ($list) {
+        $cgi->send_cookie(-name => 'COLUMNLIST',
+                          -value => $list,
+                          -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
+    }
+    else {
+        $cgi->remove_cookie('COLUMNLIST');
+    }
     if ($splitheader) {
         $cgi->send_cookie(-name => 'SPLITHEADER',
                           -value => $splitheader,