Drop superfluous isc_mem_get() NULL check

coccinelle v1.1 trips over a superfluous isc_mem_get() NULL check in
tests/libtest/ns.c and reports the following failure in CI:

    EXN: Failure("rule starting on line 26: already tagged token:\nC code context\nFile \"./tests/libtest/ns.c\", line 350, column 1, charpos = 7939\n  around = 'if',\n  whole content = \tif (qctx != NULL) {") in ./tests/libtest/ns.c

diff --git a/tests/libtest/ns.c b/tests/libtest/ns.c
index 5cca2387d9e8b48349aa6785e93ec4e3d0749013..93384803f7a1968d7d8a058ab598636782b39b48 100644 (file)
--- a/tests/libtest/ns.c
+++ b/tests/libtest/ns.c
@@ -347,15 +347,9 @@ extract_qctx(void *arg, void *data, isc_result_t *resultp) {
         * gets unwound.
         */
        qctx = isc_mem_get(mctx, sizeof(*qctx));
-       if (qctx != NULL) {
-               memmove(qctx, (query_ctx_t *)arg, sizeof(*qctx));
-       }
+       memmove(qctx, (query_ctx_t *)arg, sizeof(*qctx));
 
        qctxp = (query_ctx_t **)data;
-       /*
-        * If memory allocation failed, the supplied pointer will simply be set
-        * to NULL.  We rely on the user of this hook to react properly.
-        */
        *qctxp = qctx;
        *resultp = ISC_R_UNSET;