catz: unregister the db update-notify callback before detaching from db

When detaching from the previous version of the database, make sure
that the update-notify callback is unregistered, otherwise there is
an INSIST check which can generate an assertion failure in free_rbtdb(),
which checks that there are no outstanding update listeners in the list.

There is a similar code already in place for RPZ.

diff --git a/lib/dns/catz.c b/lib/dns/catz.c
index 97241d1352c14c5db58fc825f821fd2b3b4e5f3e..2faef31132270fbe9fa99b9dbd8c3b6bc9752109 100644 (file)
--- a/lib/dns/catz.c
+++ b/lib/dns/catz.c
@@ -2106,6 +2106,8 @@ dns_catz_dbupdate_callback(dns_db_t *db, void *fn_arg) {
                if (catz->dbversion != NULL) {
                        dns_db_closeversion(catz->db, &catz->dbversion, false);
                }
+               dns_db_updatenotify_unregister(
+                       catz->db, dns_catz_dbupdate_callback, catz->catzs);
                dns_db_detach(&catz->db);
                /*
                 * We're not registering db update callback, it will be