]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: reformat virDomainDefCompatibleDevice for upcoming additional check
authorLaine Stump <laine@redhat.com>
Thu, 9 Sep 2021 16:57:32 +0000 (12:57 -0400)
committerLaine Stump <laine@redhat.com>
Thu, 16 Sep 2021 13:29:24 +0000 (09:29 -0400)
The next patch will add another check similar to the existing check
for a change in alias name. This patch reformats the code in
preparation so that the next patch's purpose will be clear.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 858f6f923a4c0caf7dbab0f240bc924ae450bb91..73f8aade966cf3ca0e9be6d0e69d48e3eb239772 100644 (file)
@@ -28477,13 +28477,14 @@ virDomainDefCompatibleDevice(virDomainDef *def,
         data.oldInfo = virDomainDeviceGetInfo(oldDev);
 
     if (action == VIR_DOMAIN_DEVICE_ACTION_UPDATE &&
-        live &&
-        (data.newInfo && data.oldInfo &&
-         data.newInfo->alias && data.oldInfo->alias &&
-         STRNEQ(data.newInfo->alias, data.oldInfo->alias))) {
-        virReportError(VIR_ERR_OPERATION_DENIED, "%s",
-                       _("changing device alias is not allowed"));
-        return -1;
+        live && data.newInfo && data.oldInfo) {
+
+        if (data.newInfo->alias && data.oldInfo->alias &&
+            STRNEQ(data.newInfo->alias, data.oldInfo->alias)) {
+            virReportError(VIR_ERR_OPERATION_DENIED, "%s",
+                           _("changing device alias is not allowed"));
+            return -1;
+        }
     }
 
     if (!virDomainDefHasUSB(def) &&