]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
ss: mptcp: display seq related counters as decimal
authorMatthieu Baerts <matthieu.baerts@tessares.net>
Wed, 23 Aug 2023 07:24:07 +0000 (09:24 +0200)
committerStephen Hemminger <stephen@networkplumber.org>
Wed, 23 Aug 2023 15:10:34 +0000 (08:10 -0700)
This is aligned with what is printed for TCP sockets.

The main difference here is that these counters can be larger (u32 vs
u64) but WireShark and TCPDump are also printing these MPTCP counters as
decimal and they look fine.

So it sounds better to do the same here with ss for those who want to
easily count how many bytes have been exchanged between two runs without
having to think in hexa.

Acked-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
misc/ss.c

index 7ce73e610c515189d93ffd1c532641de99bc72e9..e7dc44f33a7f4f326818999606511cb02d2528ca 100644 (file)
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -3250,11 +3250,11 @@ static void mptcp_stats_print(struct mptcp_info *s)
        if (s->mptcpi_token)
                out(" token:%x", s->mptcpi_token);
        if (s->mptcpi_write_seq)
-               out(" write_seq:%llx", s->mptcpi_write_seq);
+               out(" write_seq:%llu", s->mptcpi_write_seq);
        if (s->mptcpi_snd_una)
-               out(" snd_una:%llx", s->mptcpi_snd_una);
+               out(" snd_una:%llu", s->mptcpi_snd_una);
        if (s->mptcpi_rcv_nxt)
-               out(" rcv_nxt:%llx", s->mptcpi_rcv_nxt);
+               out(" rcv_nxt:%llu", s->mptcpi_rcv_nxt);
 }
 
 static void mptcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,