check counter before accessing array. CID #1504030

diff --git a/src/lib/ldap/connection.c b/src/lib/ldap/connection.c
index 190cf64fc762bd8cb352e6758dca745a602ca4bf..9d2a1bf147cd9c5c481f042cc9a63e135e7c6307 100644 (file)
--- a/src/lib/ldap/connection.c
+++ b/src/lib/ldap/connection.c
@@ -613,7 +613,7 @@ static fr_connection_t *ldap_trunk_connection_alloc(fr_trunk_connection_t *tconn
 
 #define POPULATE_LDAP_CONTROLS(_dest, _src) do { \
        int i; \
-       for (i = 0; (_src[i].control) && (i < LDAP_MAX_CONTROLS); i++) { \
+       for (i = 0; (i < LDAP_MAX_CONTROLS) && (_src[i].control); i++) { \
                _dest[i] = _src[i].control; \
        } \
        _dest[i] = NULL; \