]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
packaging: Add missing quotes in smbprint
authorAndreas Schneider <asn@samba.org>
Wed, 19 Jun 2024 09:50:26 +0000 (11:50 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Mon, 24 Jun 2024 07:14:54 +0000 (07:14 +0000)
Found by Covscan.

"Error: SHELLCHECK_WARNING (CWE-569):
/usr/bin/smbprint:49:21: warning[SC1083]: This } is literal. Check expression (missing ;/\n?) or quote it.
   47|   #   Concat this with /.config to get the config file.
   48|   #
   49|-> eval acct_file=\${$#}
   50|   spool_dir=$(dirname $acct_file)
   51|   config_file=$spool_dir/.config"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jun 24 07:14:54 UTC 2024 on atb-devel-224

packaging/printing/smbprint

index a21385aa25c01a93d0c93c625d40396947363fb2..5439207c041dab56716acc38d451129599ccb4fb 100644 (file)
@@ -46,7 +46,7 @@
 #   Extract the directory name from the file name.
 #   Concat this with /.config to get the config file.
 #
-eval acct_file=\${$#}
+eval acct_file="\${$#}"
 spool_dir=$(dirname $acct_file)
 config_file=$spool_dir/.config