]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
comment out "skip signal" for now
authorAlan T. DeKok <aland@freeradius.org>
Tue, 8 Aug 2017 18:58:22 +0000 (20:58 +0200)
committerAlan T. DeKok <aland@freeradius.org>
Tue, 8 Aug 2017 18:58:22 +0000 (20:58 +0200)
it works in debug mode, as we're single threaded...
in daemon mode, skipping signals when there's no "next" packet
means that it just doesn't respond

We should fix the "skip signal" code to skip the signal only
if the other end hasn't ACKed our last signal.  Because when
it drains the queue, it notices that the last packet wasn't
ACKed, and sends an ACK

src/lib/io/channel.c

index 4748e4fd082ce7c15818c54fa51510333b93513e..0fac757f52bc75a03062a54a56080c1f86c2cd9b 100644 (file)
@@ -518,7 +518,7 @@ int fr_channel_send_reply(fr_channel_t *ch, fr_channel_data_t *cd, fr_channel_da
         *      predictions about packet processing time?
         */
        rad_assert(worker->their_view_of_my_sequence <= worker->sequence);
-#if ENABLE_SKIPS
+#if 0
        if (((worker->sequence - worker->their_view_of_my_sequence) <= 1000) &&
            ((when - worker->last_read_other < SIGNAL_INTERVAL) ||
             ((when - worker->last_sent_signal) < SIGNAL_INTERVAL))) {