]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Correct fastexecutemany test for lower pyodbc version
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 13 Jul 2018 02:55:01 +0000 (22:55 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 13 Jul 2018 02:55:01 +0000 (22:55 -0400)
some builds on CI have a pyodbc that is < 4.0.19, make
the check more specific

Change-Id: I69b33c2367d4a03adb00bcf52fb6d1483b0327f8

test/requirements.py

index 147b708c83d22608c995411d2df6c3eab62ac116..1d11cea4706ca37ccdaa490ec5fb9ef74f4c4f3a 100644 (file)
@@ -1083,13 +1083,17 @@ class DefaultRequirements(SuiteRequirements):
         def has_fastexecutemany(config):
             if not against(config, "mssql+pyodbc"):
                 return False
+            if config.db.dialect._dbapi_version() < (4, 0, 19):
+                return False
             with config.db.connect() as conn:
                 drivername = conn.connection.connection.getinfo(
                     config.db.dialect.dbapi.SQL_DRIVER_NAME)
                 # on linux this is 'libmsodbcsql-13.1.so.9.2'.
                 # don't know what it is on windows
                 return "msodbc" in drivername
-        return only_if(has_fastexecutemany)
+        return only_if(
+            has_fastexecutemany,
+            "only on pyodbc > 4.0.19 w/ msodbc driver")
 
     @property
     def python_fixed_issue_8743(self):