]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
bpf: Remove obsolete WARN_ON call
authorJiri Olsa <jolsa@kernel.org>
Fri, 24 Apr 2026 15:39:05 +0000 (17:39 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 27 Apr 2026 17:15:00 +0000 (10:15 -0700)
The WARN_ON call in bpf_trampoline_update could never hit, because we
direct the code path with (total == 0) to out label, which effectively
skips the WARN_ON call.

The WARN_ON made sense back then when it checked tr->selector, but now
with total being set just inside the function it's useless.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20260424153905.354922-2-jolsa@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/trampoline.c

index f02254a21585fa764d421a288fa44cd4c5a4ccc4..a4298a25d4baec66260e1202454736f2f2d251d8 100644 (file)
@@ -685,7 +685,6 @@ again:
        if (err)
                goto out_free;
 
-       WARN_ON(tr->cur_image && total == 0);
        if (tr->cur_image)
                /* progs already running at this address */
                err = modify_fentry(tr, orig_flags, tr->cur_image->image,