added a couple of FIXIT comments

diff --git a/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc b/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc
index b2af8ce7504fde44884d13901ed65122c3950bef..d1c464c1b22f6c9ec4cece61ebaec9a49d422bbc 100644 (file)
--- a/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc
+++ b/src/service_inspectors/nhttp_inspect/nhttp_msg_section.cc
@@ -110,6 +110,7 @@ void NHttpMsgSection::legacy_header(bool use_trailer) {
     legacy_cookie(header, source_id);
  }
 
+// FIXIT-M there can be multiple cookie headers in one message.
 void NHttpMsgSection::legacy_cookie(NHttpMsgHeadShared* header, SourceId source_id) {
     HeaderId cookie_head = (source_id == SRC_CLIENT) ? HEAD_COOKIE : HEAD_SET_COOKIE;
 

diff --git a/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc b/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc
index e57bdac464e1a3d6a9905a5a16611b7c14ea00dc..553f5a80366ba7636b6b7bcc7d7cfdd4793e8c42 100644 (file)
--- a/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc
+++ b/src/service_inspectors/nhttp_inspect/nhttp_splitter.cc
@@ -85,6 +85,8 @@ ScanResult NHttpHeaderSplitter::split(const uint8_t* buffer, uint32_t length) {
 
     // Header separators: leading \r\n, leading \n, nonleading \r\n\r\n, nonleading \n\r\n, nonleading \r\n\n, and
     // nonleading \n\n. The separator itself becomes num_excess which is discarded during reassemble().
+    // FIXIT-L There is a regression test with a rule that looks for these separators in the header buffer.
+    //         Need to resolve.
     for (uint32_t k = 0; k < length; k++) {
         if (buffer[k] == '\n') {
             num_crlf++;