]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bridge: dw-hdmi-qp: fix multi-channel audio output
authorJonas Karlman <jonas@kwiboo.se>
Sat, 28 Feb 2026 11:28:22 +0000 (11:28 +0000)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 17 Mar 2026 17:15:16 +0000 (18:15 +0100)
Channel Allocation (PB4) and Level Shift Information (PB5) are
configured with values from PB1 and PB2 due to the wrong offset
being used. This results in missing audio channels or incorrect
speaker placement when playing multi-channel audio.

Use the correct offset to fix multi-channel audio output.

Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp")
Reported-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://patch.msgid.link/20260228112822.4056354-1-christianshewitt@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c

index ab7fed6214e062fefe7d638fc44c0767485b60ce..facfb7526928d810e655e612ba31d728fae7a2db 100644 (file)
@@ -848,7 +848,7 @@ static int dw_hdmi_qp_config_audio_infoframe(struct dw_hdmi_qp *hdmi,
 
        regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS0, &header_bytes, 1);
        regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS1, &buffer[3], 1);
-       regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[4], 1);
+       regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[7], 1);
 
        /* Enable ACR, AUDI, AMD */
        dw_hdmi_qp_mod(hdmi,