]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
http2: only mimic http1 request if there is one 6139/head
authorPhilippe Antoine <contact@catenacyber.fr>
Thu, 22 Apr 2021 07:41:30 +0000 (09:41 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 25 May 2021 09:19:39 +0000 (11:19 +0200)
That may not be the case in midstream/async configurations

src/app-layer-http2.c

index 8576697780a5024ab62f30f0703a50885078423d..6285be9dd9d47f51e0373bc732da8b0010f89f24 100644 (file)
@@ -77,6 +77,10 @@ void HTTP2MimicHttp1Request(void *alstate_orig, void *h2s)
     if (h2s == NULL || h1tx == NULL) {
         return;
     }
+    if (h1tx->request_method == NULL) {
+        // may happen if we only got the reply, not the HTTP1 request
+        return;
+    }
 
     rs_http2_tx_set_method(h2s, bstr_ptr(h1tx->request_method), bstr_len(h1tx->request_method));
     rs_http2_tx_set_uri(h2s, bstr_ptr(h1tx->request_uri), bstr_len(h1tx->request_uri));