]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
i386: kvmvapic: initialise imm32 variable
authorPrasad J Pandit <pjp@fedoraproject.org>
Thu, 7 Apr 2016 07:20:08 +0000 (12:50 +0530)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 4 Aug 2016 20:52:54 +0000 (15:52 -0500)
When processing Task Priorty Register(TPR) access, it could leak
automatic stack variable 'imm32' in patch_instruction().
Initialise the variable to avoid it.

Reported by: Donghai Zdh <donghai.zdh@alibaba-inc.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <1460013608-16670-1-git-send-email-ppandit@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 691a02e2ce0c413236a78dee6f2651c937b09fb0)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/i386/kvmvapic.c

index c69f3740494083805d3393ea434bcdd4b0f8ed12..ff1e31a4d268f0a871d2e2101d7431d2bc907647 100644 (file)
@@ -394,7 +394,7 @@ static void patch_instruction(VAPICROMState *s, X86CPU *cpu, target_ulong ip)
     CPUX86State *env = &cpu->env;
     VAPICHandlers *handlers;
     uint8_t opcode[2];
-    uint32_t imm32;
+    uint32_t imm32 = 0;
     target_ulong current_pc = 0;
     target_ulong current_cs_base = 0;
     int current_flags = 0;