]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
i2c: mt65xx: fix IRQ check
authorSergey Shtylyov <s.shtylyov@omp.ru>
Sun, 4 Jul 2021 14:38:45 +0000 (17:38 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:41:22 +0000 (11:41 +0200)
[ Upstream commit 58fb7c643d346e2364404554f531cfa6a1a3917c ]

Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful).  Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...

Fixes: ce38815d39ea ("I2C: mediatek: Add driver for MediaTek I2C controller")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i2c/busses/i2c-mt65xx.c

index 9b867169142fd811fe1cda81d834860f9e31af8b..42a998fa5f7914e7709e90a6a766d7840d9e62ad 100644 (file)
@@ -639,7 +639,7 @@ static int mtk_i2c_probe(struct platform_device *pdev)
                return PTR_ERR(i2c->pdmabase);
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0)
+       if (irq < 0)
                return irq;
 
        init_completion(&i2c->msg_complete);