]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
regulator: pca9450: Fix enable register for LDO5
authorFrieder Schrempf <frieder.schrempf@kontron.de>
Wed, 18 Dec 2024 15:27:28 +0000 (16:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:39:12 +0000 (14:39 +0200)
[ Upstream commit f5aab0438ef17f01c5ecd25e61ae6a03f82a4586 ]

The LDO5 regulator has two configuration registers, but only
LDO5CTRL_L contains the bits for enabling/disabling the regulator.

Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Marek Vasut <marex@denx.de>
Link: https://patch.msgid.link/20241218152842.97483-6-frieder@fris.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/pca9450-regulator.c

index 9714afe347dcc0205b40243252638dff5f9298ad..1ffa145319f23938eaad954c03c5021d07432362 100644 (file)
@@ -454,7 +454,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = {
                        .n_linear_ranges = ARRAY_SIZE(pca9450_ldo5_volts),
                        .vsel_reg = PCA9450_REG_LDO5CTRL_H,
                        .vsel_mask = LDO5HOUT_MASK,
-                       .enable_reg = PCA9450_REG_LDO5CTRL_H,
+                       .enable_reg = PCA9450_REG_LDO5CTRL_L,
                        .enable_mask = LDO5H_EN_MASK,
                        .owner = THIS_MODULE,
                },
@@ -663,7 +663,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = {
                        .n_linear_ranges = ARRAY_SIZE(pca9450_ldo5_volts),
                        .vsel_reg = PCA9450_REG_LDO5CTRL_H,
                        .vsel_mask = LDO5HOUT_MASK,
-                       .enable_reg = PCA9450_REG_LDO5CTRL_H,
+                       .enable_reg = PCA9450_REG_LDO5CTRL_L,
                        .enable_mask = LDO5H_EN_MASK,
                        .owner = THIS_MODULE,
                },
@@ -835,7 +835,7 @@ static const struct pca9450_regulator_desc pca9451a_regulators[] = {
                        .n_linear_ranges = ARRAY_SIZE(pca9450_ldo5_volts),
                        .vsel_reg = PCA9450_REG_LDO5CTRL_H,
                        .vsel_mask = LDO5HOUT_MASK,
-                       .enable_reg = PCA9450_REG_LDO5CTRL_H,
+                       .enable_reg = PCA9450_REG_LDO5CTRL_L,
                        .enable_mask = LDO5H_EN_MASK,
                        .owner = THIS_MODULE,
                },