]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
phy: phy-can-transceiver: Drop the gpio desc check
authorPeng Fan <peng.fan@nxp.com>
Wed, 1 Oct 2025 13:22:35 +0000 (21:22 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 12 Nov 2025 14:41:15 +0000 (20:11 +0530)
gpiod_set_value_cansleep has an internal check on gpio_desc using
'VALIDATE_DESC(desc)', the check before invoking gpiod_set_value_cansleep
could be removed.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20251001-can-v7-4-fad29efc3884@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-can-transceiver.c

index 09d1684895568ba8bbad7cdb47bdf984966459c3..89189be9b795a626dff7046c6a60cd4b841f4f0f 100644 (file)
@@ -47,10 +47,8 @@ static int can_transceiver_phy_power_on(struct phy *phy)
                        return ret;
                }
        }
-       if (can_transceiver_phy->standby_gpio)
-               gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
-       if (can_transceiver_phy->enable_gpio)
-               gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
+       gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
+       gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
 
        return 0;
 }
@@ -61,10 +59,8 @@ static int can_transceiver_phy_power_off(struct phy *phy)
        struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
        struct can_transceiver_priv *priv = can_transceiver_phy->priv;
 
-       if (can_transceiver_phy->standby_gpio)
-               gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
-       if (can_transceiver_phy->enable_gpio)
-               gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
+       gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
+       gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
        if (priv->mux_state)
                mux_state_deselect(priv->mux_state);