]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: dac: ti-dac5571: Fix alignment for DMA safety
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 May 2022 17:56:42 +0000 (18:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:41:32 +0000 (14:41 +0200)
[ Upstream commit 58e22371539e01c742be5c30295f591a6a17e348 ]

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Fixes: df38a4a72a3b ("iio: dac: add TI DAC5571 family support")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-63-jic23@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/dac/ti-dac5571.c

index 0b775f943db3e7da6c9915976aca6181e110bea5..ba68ea1e3455db662fccee561e1c834478d6de71 100644 (file)
@@ -52,7 +52,7 @@ struct dac5571_data {
        struct dac5571_spec const *spec;
        int (*dac5571_cmd)(struct dac5571_data *data, int channel, u16 val);
        int (*dac5571_pwrdwn)(struct dac5571_data *data, int channel, u8 pwrdwn);
-       u8 buf[3] ____cacheline_aligned;
+       u8 buf[3] __aligned(IIO_DMA_MINALIGN);
 };
 
 #define DAC5571_POWERDOWN(mode)                ((mode) + 1)