]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/radeon: Fix integer overflow in radeon_cs_parser_init
authorhackyzh002 <hackyzh002@gmail.com>
Wed, 19 Apr 2023 12:20:58 +0000 (20:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2023 14:35:08 +0000 (16:35 +0200)
[ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ]

The type of size is unsigned, if size is 0x40000000, there will be an
integer overflow, size will be zero after size *= sizeof(uint32_t),
will cause uninitialized memory to be referenced later

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/radeon/radeon_cs.c

index 1ae31dbc61c64a2fbf30ede3a84fa0ea315fe8b5..5e61abb3dce5c8b9bec6eaac9f248a68557c5b0c 100644 (file)
@@ -265,7 +265,8 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
 {
        struct drm_radeon_cs *cs = data;
        uint64_t *chunk_array_ptr;
-       unsigned size, i;
+       u64 size;
+       unsigned i;
        u32 ring = RADEON_CS_RING_GFX;
        s32 priority = 0;