]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: usb-audio: Fix build with CONFIG_INPUT=n
authorTakashi Iwai <tiwai@suse.de>
Fri, 13 Jun 2025 08:15:30 +0000 (10:15 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 13 Jun 2025 09:52:43 +0000 (11:52 +0200)
The recent addition of DualSense mixer quirk relies on the input
device handle, and the build can fail if CONFIG_INPUT isn't set.
Put (rather ugly) workarounds to wrap with IS_REACHABLE() for avoiding
the build error.

Fixes: 79d561c4ec04 ("ALSA: usb-audio: Add mixer quirk for Sony DualSense PS5")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506130733.gnPKw2l3-lkp@intel.com/
Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://patch.msgid.link/20250613081543.7404-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_quirks.c

index a0ffe8b559dcc2010d5c0501d4d31ac6936a07ff..7cc27ae5512f07d5318443a7e03c1da7943bfb7a 100644 (file)
@@ -532,6 +532,7 @@ static int snd_emu0204_controls_create(struct usb_mixer_interface *mixer)
                                          &snd_emu0204_control, NULL);
 }
 
+#if IS_REACHABLE(CONFIG_INPUT)
 /*
  * Sony DualSense controller (PS5) jack detection
  *
@@ -788,6 +789,7 @@ static int snd_dualsense_controls_create(struct usb_mixer_interface *mixer)
 
        return snd_dualsense_jack_create(mixer, "Headset Mic Jack", false);
 }
+#endif /* IS_REACHABLE(CONFIG_INPUT) */
 
 /* ASUS Xonar U1 / U3 controls */
 
@@ -4331,10 +4333,12 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer)
                err = snd_emu0204_controls_create(mixer);
                break;
 
+#if IS_REACHABLE(CONFIG_INPUT)
        case USB_ID(0x054c, 0x0ce6): /* Sony DualSense controller (PS5) */
        case USB_ID(0x054c, 0x0df2): /* Sony DualSense Edge controller (PS5) */
                err = snd_dualsense_controls_create(mixer);
                break;
+#endif /* IS_REACHABLE(CONFIG_INPUT) */
 
        case USB_ID(0x0763, 0x2030): /* M-Audio Fast Track C400 */
        case USB_ID(0x0763, 0x2031): /* M-Audio Fast Track C400 */