]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
rust(lint): replace checked_mul with saturating_mul
authorJason Ish <jason.ish@oisf.net>
Fri, 20 Aug 2021 17:29:37 +0000 (11:29 -0600)
committerVictor Julien <victor@inliniac.net>
Mon, 23 Aug 2021 08:03:12 +0000 (10:03 +0200)
When defaulting checked_mul to u64::max, Rust has a method
that does the same thing called saturating_mul.

rust/src/asn1/mod.rs

index e4086b628fabc6b3cad5c8590bda2e6a9eb9d7ff..7d33bc0a9bb869e0fdfe0d7f7067276ac24a9e5c 100644 (file)
@@ -102,7 +102,7 @@ impl<'a> Asn1<'a> {
         {
             if let BerObjectContent::BitString(bits, _v) = &obj.content {
                 if obj.header.len > 0
-                    && *bits as u64 > (obj.header.len.checked_mul(8).unwrap_or(std::u64::MAX))
+                    && *bits as u64 > obj.header.len.saturating_mul(8)
                 {
                     return Some(Asn1Check::BitstringOverflow);
                 }